fix: Error: EACCES: permission denied for corepack #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
Apr 5, 2024
| @@ -29,7 +29,7 @@ build: | |||
| rm -rf node_modules; \ | |||
| fi | |||
| @which corepack > /dev/null || (echo "Installing corepack..." && npm install -g corepack) | |||
| @cd frontend && corepack enable && pnpm install && pnpm run make-i18n | |||
| @cd frontend && sudo corepack enable && pnpm install && pnpm run make-i18n | |||
There was a problem hiding this comment.
🤔 this could cause issues in other environments. I generally try to avoid putting sudo inside a script like this
Does running sudo make build work? Any other options here?
There was a problem hiding this comment.
Agree, prefer not use sudo in script.
|
I think the problem in #734 is more like the user didn't launch docker locally. Not permission problem. |
|
Looks like pnpm is gone, so we can close this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #734