Updates logentry_args.md #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates the headline * Adds an introduction and some specification * Splits the table into two tables, defined and not yet defined names * Removes old list not relevant
matsduf
added
A-TestCase
mattias-p
reviewed
Nov 8, 2021
mattias-p
reviewed
Nov 8, 2021
docs/logentry_args.md
Outdated
Comment on lines
7
to
8
| Zonemaster messages. The messages are defined in the Perl modules for the test | ||
| cases, e.g. [Basic.pm], and translated in the PO files, e.g. [fr.po] and [sv.po]. |
There was a problem hiding this comment.
Some messages are also defined in Zonemaster::Engine::Translator.
There was a problem hiding this comment.
Good point. I should have checked. I changed to "are primarily defined in".
* Some editorial updates * Consistent use "message" * Consistent definition of "argument"
matsduf
commented
Nov 10, 2021
docs/logentry_args.md
Outdated
Comment on lines
7
to
8
| Zonemaster messages. The messages are defined in the Perl modules for the test | ||
| cases, e.g. [Basic.pm], and translated in the PO files, e.g. [fr.po] and [sv.po]. |
There was a problem hiding this comment.
Good point. I should have checked. I changed to "are primarily defined in".
|
@mattias-p and @vlevigneron, can you (re-)review this? |
mattias-p
approved these changes
Nov 11, 2021
|
@vlevigneron, does this looks good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
logentry_args.mddefines argument names to be used in messages, but there is a limitation in the message model. An argument name can only be used once in the same message. This PR specifies a method to extend the name for such cases.This PR also:
How to test this PR
This is document only, but the new method is already used in #995.