CDS/CDNSKEY test cases improvements (DNSSEC15/DNSSEC16/DNSSEC17) #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlevigneron
changed the title
matsduf
previously approved these changes
Oct 24, 2021
|
Sorry @matsduf I did not see your approval. I add a cosmetic change. |
matsduf
approved these changes
Oct 24, 2021
This was referenced Oct 27, 2021
Testing v2021.2LGTM. I tested available test zones and compared with the output when using dig. |
matsduf
added
A-TestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR add new tests and message in DNSSEC16 and DNSSEC17 (Cf zonemaster/zonemaster#966).
This PR also add a complete set of unit tests for the 2 methods (all message tags are tested)
This PR also add missing unit test for DNSSEC15
Context
Fixes #988
Fixes #907
Fixes #896
Changes
methods Zonemaster::Engine::Test::DNSSEC::dnssec16 and Zonemaster::Engine::Test::DNSSEC::dnssec17 modified with new messages
6 new messages tag implemented (no translation yet)
Unit tests updated (no more unit tests missing)
How to test this PR
Use one of the following domains to do the tests:
DNSSEC15:
dnssec15-mismatch-cds-cdnskey.zft-root.rd.nic.fr
DNSSEC16 :
dnssec16-cds-cdnskey-signed.zft-root.rd.nic.fr
dnssec16-cds-cdnskey-unsigned.zft-root.rd.nic.fr
dnssec16-cds-cdnskey-invalid-rrsig-01.zft-root.rd.nic.fr
dnssec16-cds-cdnskey-invalid-rrsig-02.zft-root.rd.nic.fr
dnssec16-cds-unsigned.zft-root.rd.nic.fr
dnssec16-delete-cds.zft-root.rd.nic.fr
dnssec16-cds-without-dnskey.zft-root.rd.nic.fr
dnssec16-mixed-delete-cds.zft-root.rd.nic.fr
dnssec16-cds-matches-no-dnskey.zft-root.rd.nic.fr
dnssec16-cds-matches-non-sep-dnskey.zft-root.rd.nic.fr
dnssec16-cds-signed-by-unknown-dnskey.zft-root.rd.nic.fr
dnssec16-cds-matches-non-zone-dnskey.zft-root.rd.nic.fr
DNSSEC17:
dnssec16-cds-cdnskey-signed.zft-root.rd.nic.fr
dnssec16-cds-cdnskey-unsigned.zft-root.rd.nic.fr
dnssec16-cds-cdnskey-invalid-rrsig-01.zft-root.rd.nic.fr
dnssec16-cds-cdnskey-invalid-rrsig-02.zft-root.rd.nic.fr
dnssec17-cdnskey-unsigned.zft-root.rd.nic.fr
dnssec16-cds-without-dnskey.zft-root.rd.nic.fr
dnssec17-cdnskey-signed-by-unknown-dnskey.zft-root.rd.nic.fr
dnssec17-cdnskey-matches-no-dnskey.zft-root.rd.nic.fr
dnssec17-delete-cdnskey.zft-root.rd.nic.fr
dnssec17-mixed-delete-cdnskey.zft-root.rd.nic.fr
dnssec17-cdnskey-is-non-zone.zft-root.rd.nic.fr