Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Finnish PO file (Engine) #880

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Feb 12, 2021

This PO file has been sent by email by translator. It needs some corrections before it can be merged. This resolves #879.

@matsduf matsduf added the A-Translation Area: Documentation of, implementation of or actual translation of text label Feb 12, 2021
@matsduf matsduf added this to the v2021.1 milestone Feb 12, 2021
@matsduf matsduf self-assigned this Feb 12, 2021
share/fi.po Show resolved Hide resolved
share/fi.po Outdated Show resolved Hide resolved
share/fi.po Outdated Show resolved Hide resolved
@matsduf
Copy link
Contributor Author

matsduf commented Feb 12, 2021

@samisalmensuo, can you look at this?

@matsduf matsduf changed the title Add Finnish PO file Add Finnish PO file (Engine) Feb 12, 2021
@matsduf matsduf linked an issue Feb 13, 2021 that may be closed by this pull request
Copy link
Collaborator

@samisalmensuo samisalmensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope i understood the problems correctly. :)

share/fi.po Show resolved Hide resolved
share/fi.po Show resolved Hide resolved
share/fi.po Outdated Show resolved Hide resolved
share/fi.po Outdated Show resolved Hide resolved
@matsduf
Copy link
Contributor Author

matsduf commented Feb 16, 2021

Uppdated with corrections provided by @samisalmensuo. Fuzzy marks then removed.

@samisalmensuo, the fuzzy marks were set by the gettext program when it provided msgstr strings by guessing.

@matsduf matsduf requested review from mattias-p, a user and samisalmensuo February 16, 2021 21:02
@matsduf
Copy link
Contributor Author

matsduf commented Mar 12, 2021

@pnax and @mattias-p, can you approve?

mattias-p
mattias-p previously approved these changes Mar 12, 2021
@matsduf
Copy link
Contributor Author

matsduf commented Mar 15, 2021

Rebased on develop branch with corrected unit test data. No change of the PR as such.

@matsduf matsduf requested a review from mattias-p March 15, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Finnish translation
3 participants