Fix installation from dist tarball #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix we end up requiring xgettext on installation, which isn't supposed to be needed.
matsduf
reviewed
Oct 15, 2020
| @@ -2,7 +2,7 @@ | |||
| .SUFFIXES: .po .mo | |||
| .PHONY: all check-msg-args dist extract-pot tidy-po show-fuzzy touch-po update-po | |||
|
|
|||
| POFILES != echo *.po | |||
| POFILES != find . -type f -name '*.po' | |||
There was a problem hiding this comment.
This will find files further down. "-depth0", maybe?
There was a problem hiding this comment.
I doubt there will be any. But sure, I'll add that as a drive-by fix in a future PR.
matsduf
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes installation from dist tarball. The problem is that
*.poisn't expanded to the empty string if there are no PO files. One thing leads to another and all of a suddenxgettextis required at installation time, which it's not supposed to be.The PR also includes a small simplification of the installation instruction.