-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename more message args #799
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fde74e2
Fix message arg name mismatch
mattias-p b64d7f3
Rename message arg: addrs
mattias-p e4a87f1
Rename message arg: servers
mattias-p ee9076a
Rename message arg: glue
mattias-p 00e719f
Rename message args: parent_addresses, zone_addresses
mattias-p 00a844e
Rename message arg: addresses
mattias-p 6820639
Refactor
mattias-p bda4006
Rename message arg: nsset
mattias-p 02189bd
Rename message arg: names
mattias-p 63228ac
Clarify usage of suffixes
mattias-p 0a2c1a6
Revert suffixed argument names
mattias-p bf127cf
Rename nssset argument
mattias-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have changed this document from a list of defined argument names to something more complex that includes something called "base name" and some kind of rules for suffixing, which means that a name has some kind of morphology or syntax.
I prefer if this is a list defined argument names, i.e. names without formal internal structure. At least as a start.
If you go the second way, some terms must be defined and the rules must be specified. Still, the suffixes or prefixes must be listed and defined. It must be possible, as a translator, to go into the list and find the argument name and figure out what kind of data it is.