Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message argument names in PO files #796

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Update message argument names in PO files #796

merged 5 commits into from
Sep 30, 2020

Conversation

mattias-p
Copy link
Member

The main thing here is that I've run update-po after merging #792 and adjusted all msgstr strings accordingly.

This PR also includes a few other fixes:

  • Correction of an error I made in Update ns args in SYSTEM messages #792.
  • A new make target (tidy-po) for tidying up the formatting in PO files without changing their substance.
  • Tidying up of the formatting int the PO files.
  • Maintenance of phony targets in share/Makefile.

@matsduf matsduf added A-Translation Area: Documentation of, implementation of or actual translation of text P-High Priority: Issue to be solved before other labels Sep 30, 2020
@matsduf matsduf added this to the v2020.1 milestone Sep 30, 2020
@matsduf
Copy link
Contributor

matsduf commented Sep 30, 2020

I assume that you want this to be merged with the v2020.1 release.

The new tydy-po command (target) will tidy all PO files, won't it? It will mean that it is not the best for the translators. Or what is your idea?

@mattias-p
Copy link
Member Author

I created make tidy-po to help out with my own workflow in making this PR. I guess it could be nice for translators as well.

matsduf
matsduf approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could provide the PO file to tidy, then it would be nice for all translators and could be integrated in the instructions for the translators, e.g.

make tidy-po sv.po

@mattias-p
Copy link
Member Author

I created #797 regarding the creation of a translator friendly tidy tool.

@mattias-p mattias-p merged commit 15db86e into zonemaster:develop Sep 30, 2020
@mattias-p mattias-p deleted the 713-ns-args-4 branch January 7, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsduf matsduf matsduf approved these changes

@sandoche2k sandoche2k sandoche2k approved these changes

Assignees
No one assigned
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text P-High Priority: Issue to be solved before other
Projects
None yet
Milestone
v2020.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mattias-p @matsduf @sandoche2k