Silence PACKET_BIG for the time being #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even as DEBUG message, it is an incorrect message. From #731: "If this test is kept as-is, it should be down graded to DEBUG and the message should be changed so that nothing is indicated that the size over some limit, just indicate that it is a large message." Can you also change the message too, e.g.: "Big packet size ({size}) (try with "{command}")." |
|
Sure. I updated the message per your suggestion. |
matsduf
approved these changes
Sep 21, 2020
vlevigneron
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#731 suggests that this message should be demoted to DEBUG until it is properly documented and implemented. This PR contains the demotion part.