Update to make Makefile POSIX compliant. #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
added
T-Bug
mattias-p
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share/Makefile does not work with FreeBSD when a PO file is to be updated. This applies to the develop branch where GNU Make should not be needed after update by PR #726. Running
make sv.poormake update-poonly creates "Zonemaster-Engine.pot" but it does not update the PO files. In master branch and usinggmake(FreeBSD GNU Make) it works.The change in this PR makes it work under FreeBSD with normal
makeand it still works with Linux (tested on Ubuntu 18.04) with GNU Make (which ismakein Linux).