Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List IPv6 addresses in IPv6 message #685

Closed
wants to merge 1 commit into from
Closed

List IPv6 addresses in IPv6 message #685

wants to merge 1 commit into from

Conversation

quinot
Copy link
Contributor

@quinot quinot commented Mar 13, 2020

Fixes issue mentioned on #523: IPv4 addresses are listed instead of IPv6 addresses in the [NOT_]ENOUGH_IPV6_NS_CHILD messages.

Fixes issue mentioned on #523
@quinot
Copy link
Contributor Author

quinot commented Mar 15, 2020

It seems that the Travis build failed for reasons unrelated to the change.

@matsduf matsduf self-assigned this Mar 16, 2020
@matsduf matsduf added A-TestCase Area: Test case specification or implementation of test case T-Bug Type: Bug in software or error in test case description labels Mar 16, 2020
@matsduf
Copy link
Contributor

matsduf commented Mar 16, 2020

@quinot, thank you for your contribution. The issue was already identified in #545 and has been corrected by pull request #552. The PR was merged to the develop branch quite a while ago, but for various reasons the release has not yet been finalized. At release, the develop branch will be merged into the master branch.

The way we work is that all changes between releases are added to the develop branch to keep the master branch stable and consistent.

I agree that the Travis issue seems to be unrelated.

Thank you again. Everything you find is welcome as issue or pull request, but then against the develop branch is better.

@matsduf matsduf closed this Mar 16, 2020
@quinot
Copy link
Contributor Author

quinot commented Mar 17, 2020

Ah! I missed the develop branch, sorry for the noise. While I'm at it, is it of interest if I submit a new PR just for the test case? (AFAICT there is currently none)

@matsduf
Copy link
Contributor

matsduf commented Mar 18, 2020

No problem. Yes, please. Add a PR to the develop branch for the test case. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants