- Fixes zonemaster/zonemaster-engine#595 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlevigneron
requested review from
matsduf and
mattias-p
and removed request for
matsduf
matsduf
requested changes
Oct 4, 2019
|
We need PR zonemaster/zonemaster#802 to be approved and merged before this PR can be approved since it now is based on the change by zonemaster/zonemaster#802. |
matsduf
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ZONE10 implementation.
Non regression test cases are missing. Not easy to create zones with multiple or wrong SOA. Bind do not load that kind of zone.
Resolves issue #595.