Verify absence of fuzzy translations #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
previously approved these changes
Oct 3, 2019
matsduf
requested changes
Oct 11, 2019
|
Rebased onto current develop. |
matsduf
reviewed
Oct 18, 2019
|
Yeah, I'm cleaning it up. Let's see if we actually need the PO files in the MANIFEST. |
|
It finally passes Travis, and I've cleaned up the accidentally included changes. @matsduf, @vlevigneron Please review again. |
matsduf
requested changes
Oct 18, 2019
| } | ||
|
|
||
| subtest "no fuzzy marks" => sub { | ||
| my @fuzzy_po_files = qw( da.po fr.po sv.po ); |
There was a problem hiding this comment.
Is this a list of po files that must be fuzzy free or may have "fuzzy"? What about en.po?
Why not fetch from share/ instead to make it catch future languages automatically?
There was a problem hiding this comment.
Since the "fuzzy" has been removed from sv and da I do not see any reason to keep those on a white list (or black list), but OK.
This was referenced Oct 18, 2019
matsduf
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new unit test ensuring that we don't accept fuzzy markings in PO files into the develop branch.
Three out of four PO files do contain fuzzy entries, so they have been added to a whitelist to be opted out of this check. For each one there is an issue to clean up the PO file:
sv.pofr.poda.poThere is also an issue (#597) to clean up the whitelist mechanism once all PO files have been removed from the whitelist.