Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Fixes zonemaster/zonemaster-engine#584 #586

Merged
merged 7 commits into from
Oct 3, 2019
Merged

- Fixes zonemaster/zonemaster-engine#584 #586

merged 7 commits into from
Oct 3, 2019

Conversation

vlevigneron
Copy link
Contributor

@vlevigneron vlevigneron commented Sep 24, 2019 •
edited by matsduf
Loading

  • Implement DNSSEC14
  • Translation is coming...

Resolves #584

@vlevigneron
- Fixes zonemaster#584
1c11252 
- Implement DNSSEC14
@matsduf matsduf added this to the v2019.2 milestone Sep 24, 2019
@vlevigneron vlevigneron mentioned this pull request Sep 25, 2019
Merged
matsduf
matsduf requested changes Sep 25, 2019
View reviewed changes
lib/Zonemaster/Engine/Test/DNSSEC.pm Show resolved Hide resolved
lib/Zonemaster/Engine/Test/DNSSEC.pm Outdated Show resolved Hide resolved
lib/Zonemaster/Engine/Test/DNSSEC.pm Outdated Show resolved Hide resolved
lib/Zonemaster/Engine/Test/DNSSEC.pm Outdated Show resolved Hide resolved
mattias-p
mattias-p previously approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Found a couple of nits.

lib/Zonemaster/Engine/Test/DNSSEC.pm Outdated Show resolved Hide resolved
lib/Zonemaster/Engine/Test/DNSSEC.pm Outdated Show resolved Hide resolved
@matsduf
Copy link
Contributor

matsduf commented Sep 26, 2019

Should this PR update one of the po files? All po files will be updated by #588.

@vlevigneron
Copy link
Contributor Author

@matsduf Good question. There are some translation needs here. We can decide to wait for merge of #588, remove po file of this PR and create a new issue to do the translation after.

@mattias-p
Copy link
Member

The current documentation states that the programmer should update PO files. However I think there's a better way that we should adopt. I reread the translation documentation and came up with a couple of other thinks as well, so I created #594.

matsduf
matsduf previously approved these changes Oct 3, 2019
View reviewed changes
@vlevigneron
Copy link
Contributor Author

@matsduf can you approve it again ? There was a missing message preventing Travis to succeed. It has been fixed in the last commit.

@vlevigneron vlevigneron merged commit a4d9584 into zonemaster:develop Oct 3, 2019
@vlevigneron vlevigneron mentioned this pull request Oct 3, 2019
Closed
@matsduf matsduf mentioned this pull request Oct 3, 2019
Closed
@vlevigneron vlevigneron deleted the issue-zonemaster-engine-584 branch May 2, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsduf matsduf matsduf approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2019.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vlevigneron @matsduf @mattias-p