Partial fix for translation on FreeBSD 11 #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation respects priorities specified by POSIX as GNU extensions on OSes where they are applicable.
matsduf
requested changes
Jun 13, 2019
|
I'd say these are low-risk changes. They should have no negative effect on compliant platforms. Just for the sake of it I verified that translations still work as expected on both Debian 8 and 9. |
|
@matsduf I'm posing the same questions here that I posed in zonemaster/zonemaster-backend#526: What changes are you requesting? Do you think that no fix is better than this partial fix as currently implemented? I've spent a fair amount of time on this already and intend to shift my focus to other things. |
matsduf
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a partial fix for #546. It makes it possible to select translation for a single locale, but once you do that, translations stuck on that locale and you cannot switch to another. This is good enough for applications like Zonemaster CLI, but not Zonemaster Backend RPCAPI (which I believe reuses the same process for multiple requests).
The remaining commits are just other improvements I came up with while working on #546.