normalization.t: Avoid non-ASCII characters in test names and notes #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid printing non-ASCII characters to STDOUT/STDERR, test names and notes use strings converted to \x escape sequences. This is a quick and dirty fix; maybe other places in the code could benefit from this little conversion function.
marc-vanderwal
requested review from
hannaeko,
matsduf,
mattias-p,
a user and
tgreenx
marc-vanderwal
added
the
T-Bug
matsduf
approved these changes
Nov 28, 2022
tgreenx
approved these changes
Nov 30, 2022
|
Let’s merge it, then. |
matsduf
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds measures to avoid attempting to print non-ASCII characters in the names of (sub)tests and in the test notes. It does so by hex-escaping any character whose code point lies outside the U+0020–U+007F range.
It’s a quick-and-dirty fix just before a release. Maybe the code I introduced could be added to a “util” package later.
Context
Fixes #1153.
Changes
Avoid non-ASCII characters in test names and notes.
How to test this PR
Run the t/normalization.t unit test. No “Wide character in print” warning should appear anymore.