Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects argument in zone09 #1139

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Corrects argument in zone09 #1139

merged 1 commit into from
Oct 13, 2022

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Oct 12, 2022

Purpose

Incorrect argument name was chosen in Zone09. This PR corrects that.

Context

Implements zonemaster/zonemaster#1104

How to test this PR

  1. Clone the Zonemaster-Engine repository
  2. Go to the share directory
  3. Run ./update-po fi.po (or some other PO file)
  4. Find the message for Z09_MX_DATA
  5. Verify that the message uses an argument with name mailtarget_list and not domain_list.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Oct 12, 2022
@matsduf matsduf requested review from a user and tgreenx October 12, 2022 15:52
@matsduf matsduf mentioned this pull request Oct 12, 2022
Merged
marc-vanderwal
marc-vanderwal approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@matsduf matsduf merged commit 92f579f into zonemaster:develop Oct 13, 2022
@matsduf matsduf deleted the correct-zone09 branch October 13, 2022 08:33
@matsduf matsduf added the V-Patch Versioning: The change gives an update of patch in version. label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes

@tgreenx tgreenx Awaiting requested review from tgreenx

Assignees
No one assigned
Labels
A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matsduf @marc-vanderwal