Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified use of "domain" argument #1135

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Oct 6, 2022

Purpose

This clarifies the use of the domain argument. Relates to zonemaster/zonemaster#1104

How to test this PR

Review only.

@matsduf matsduf added this to the v2022.2 milestone Oct 6, 2022
@matsduf matsduf requested review from mattias-p and a user October 6, 2022 16:13
Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@matsduf matsduf merged commit b1853f7 into zonemaster:develop Oct 11, 2022
@matsduf matsduf deleted the clarify-argument branch October 11, 2022 14:53
@matsduf matsduf added the V-Patch Versioning: The change gives an update of patch in version. label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants