Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowercase fragments to refer to internal headings #1127

Merged
1 commit merged into from Sep 5, 2022
Merged

Use lowercase fragments to refer to internal headings #1127

1 commit merged into from Sep 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 1, 2022

Purpose

When it comes to referring to internal anchors, we used a mix of upper and lower cases in our Markdown documents. It appears that Github handles this well, but other Markdown to HTML engines suffer to link to the related identifier on the page since they are looking for a perfect match (case sensitively).
This PR is about downcasing all fragments in our Markdown documents.

Context

n/a

Changes

Downcase all fragments that refer to internal anchors in our Markdown documents.

How to test this PR

Documentation only. Links with the updated fragments should work properly once rendered.

@ghost ghost added this to the v2022.2 milestone Sep 1, 2022
@ghost ghost requested review from matsduf, mattias-p and tgreenx September 1, 2022 14:09
@ghost ghost merged commit ea1e926 into zonemaster:develop Sep 5, 2022
@ghost ghost deleted the header-links-lowercase branch September 5, 2022 10:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant