Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove special SHA-1 treatment from DNSSEC01 #1116

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Remove special SHA-1 treatment from DNSSEC01 #1116

merged 2 commits into from
Aug 2, 2022

Conversation

tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Aug 2, 2022

Purpose

This PR removes the special treatment of SHA-1 from DNSSEC01, following the update on the specification.

Context

Fixes #1115

Changes

  • Remove DS01_DS_ALGO_SHA1_DEPRECATED messages from test case and profile
  • Output DS01_DS_ALGO_DEPRECATED for SHA-1 (Algo 1)
  • Update DNSSEC01 unitary tests

How to test this PR

Tests should pass.

zonemaster-cli --show-testcase --test dnssec/dnssec01 dnssec01-ds-algorithm-deprecated1.zut-root.rd.nic.fr --raw
   1.04 ERROR     DNSSEC01       DS01_DS_ALGO_DEPRECATED   domain=dnssec01-ds-algorithm-deprecated1.zut-root.rd.nic.fr; ds_algo_mnemo=SHA-1; ds_algo_num=1; keytag=8011; ns_ip_list=145.239.76.200;145.239.76.202
   1.04 NOTICE    DNSSEC01       DS01_DS_ALGO_2_MISSING   domain=dnssec01-ds-algorithm-deprecated1.zut-root.rd.nic.fr

@tgreenx tgreenx added the A-TestCase Area: Test case specification or implementation of test case label Aug 2, 2022
@tgreenx tgreenx added this to the v2022.2 milestone Aug 2, 2022
@tgreenx tgreenx linked an issue Aug 2, 2022 that may be closed by this pull request
Implementation of DNSSEC01 #1115
Closed
@tgreenx tgreenx merged commit 259ccec into zonemaster:develop Aug 2, 2022
@tgreenx tgreenx deleted the patch#1115 branch August 2, 2022 14:30
@tgreenx tgreenx mentioned this pull request Sep 8, 2022
Closed
@ghost ghost added the S-ReleaseTested Status: The PR has been successfully tested in release testing label Dec 8, 2022
@matsduf matsduf added the V-Minor Versioning: The change gives an update of minor in version. label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matsduf matsduf matsduf approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees
No one assigned
Labels
A-TestCase Area: Test case specification or implementation of test case S-ReleaseTested Status: The PR has been successfully tested in release testing V-Minor Versioning: The change gives an update of minor in version.
Projects
None yet
Milestone
v2022.2
Development

Successfully merging this pull request may close these issues.

Implementation of DNSSEC01
2 participants
@tgreenx @matsduf