Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes moved translator instruction #1009

Merged

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Nov 19, 2021

zonemaster/zonemaster#1015 moves the translator instruction to the main Zonemaster repository, or technically add such a document there. When that PR has been merged, the PR should be merged to remove it from this repository.

  • Remove the instruction for translators. Has been created in zonemaster/zonemaster instead.
  • Replace moved document with a document with referral.
  • Update link in the general translation document.

Please note that the link in the document does not work until zonemaster/zonemaster#1015 has been merged.

How to test this PR

Documentation only.

* Remove the instruction for translators. Has been created
  in zonemaster/zonemaster instead.
* Replace moved document with a document with referral.
* Update link in the general translation document.
@matsduf matsduf added the A-Documentation Area: Documentation only. label Nov 19, 2021
@matsduf matsduf added this to the v2021.2 milestone Nov 19, 2021
@matsduf matsduf requested review from mattias-p, hannaeko and a user November 19, 2021 16:42
mattias-p
mattias-p previously approved these changes Nov 22, 2021
Comment on lines 1 to 3
This document has been moved to the main Zonemaster repository.

See the general [Translation] document for overall documentation on
translation.
Go to "[Instructions for translators]".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just like this?

This document has moved [here][Instructions for translators].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I do not see why that should be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's shorter and more straight to the point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were two lines and one link. It would work fine.

@matsduf matsduf merged commit 7f8bd84 into zonemaster:develop Nov 25, 2021
@matsduf matsduf deleted the removes-moved-translator-instructions branch November 25, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants