Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Consistency05 does not find names in subzone #742

Closed
matsduf opened this issue May 28, 2020 · 0 comments · Fixed by #759
Closed

Implementation of Consistency05 does not find names in subzone #742

matsduf opened this issue May 28, 2020 · 0 comments · Fixed by #759
Assignees
Labels
A-TestCase Area: Test case specification or implementation of test case T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented May 28, 2020

Testing ".fr" results in error in Consistency05:

$ zonemaster-cli --show_module --raw --test consistency/consistency05 fr
18.80 ERROR CONSISTENCY CONSISTENCY:IN_BAILIWICK_ADDR_MISMATCH parent_addresses=d.nic.fr./194.0.9.1; d.nic.fr./2001:678:c::1; e.ext.nic.fr./193.176.144.22; e.ext.nic.fr./2a00:d78:0:102:193:176:144:22; f.ext.nic.fr./194.146.106.46; f.ext.nic.fr./2001:67c:1010:11::53; g.ext.nic.fr./194.0.36.1; g.ext.nic.fr./2001:678:4c::1; zone_addresses=

Zonemaster looks for the address records of d.nic.fr, e.ext.nic.fr, f.ext.nic.fr and g.ext.nic.fr in the .fr zone, but they are not included in the zone (as authoritative data) since nic.fr is delegated to another set of nameservers.

Consistency05 says somewhere in the middle of the ordered description the following which is meant to cover that situation:

      3. Or, if the response is a delegation (referral) to a 
         sub-zone of *Child Zone*, then:
         1. Copy the adress query (A, AAAA) that gave the referral
            response.
         2. Set the RD flag in the copied query (from unset to set).
         3. Do a [DNS Lookup][terminology] of the the query.
         4. If the lookup returns the relevant address record or records,
            A for A record query and AAAA for AAAA record query, and 
            with the same owner name as in the query (i.e. CNAME should
            not be followed), then extract those and add to 
            *Address Records From Child* with name and IP 
            address or addresses.

The implementation of Consistency05 does not seem to follow these steps.

@matsduf matsduf added T-Bug Type: Bug in software or error in test case description A-TestCase Area: Test case specification or implementation of test case labels May 28, 2020
@matsduf matsduf added this to the v2020.1 milestone May 28, 2020
vlevigneron added a commit to vlevigneron/zonemaster-engine that referenced this issue Jul 23, 2020
@matsduf matsduf linked a pull request Jul 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants