Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spanish translation as requested in issue #322 #329

Merged
merged 1 commit into from
May 31, 2023

Conversation

huguei
Copy link
Collaborator

@huguei huguei commented May 22, 2023

Purpose

This PR updates spanish translation to keep in sync with develop branch.
Please note poedit tool reorder the messages so it appears more changes than effective.

Context

#322

Changes

share/es.po

@matsduf matsduf added A-Translation Area: Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version. labels May 23, 2023
@matsduf matsduf added this to the v2023.1 milestone May 23, 2023
@matsduf matsduf linked an issue May 23, 2023 that may be closed by this pull request
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues.

Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a Spanish speaker, but I see no issues either.

@matsduf
Copy link
Contributor

matsduf commented May 23, 2023

@huguei, do you want to take a second review before we merge? We do not have any speaking Spanish here.

@huguei
Copy link
Collaborator Author

huguei commented May 24, 2023

I did a second check and it seems ready to go. Please proceed.

Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't speak Spanish, I have just one comment but otherwise it looks fine.

"Only one domain can be given for testing. Did you forget to prepend an "
"option with '--<OPTION>'?\n"
msgstr ""
"Solo puede indicarse 1 dominio para las pruebas. ¿Quizás incluyó una opción "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the translated string (msgstr) the numeral of "one" is provided ("1"), while the original string (msgid) does not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huguei, please comment. Should it be updated? If yes, I can easily do it if you write to what.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you careful review @tgreenx , but no, it's clearer with a number. In Spanish the word "un" can indicate an indefinite article ("a/an") or the number 1, and in this case saying "Solo puede indicarse un dominio para las pruebas" is pretty vague. Sounds equivalent to "only any domain can be given for testing". In contrast, "only 1 domain can be indicated for testing" is unambiguous that it refers to quantity!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @huguei! I will merge.

@matsduf matsduf merged commit 44d607b into zonemaster:develop May 31, 2023
@huguei huguei deleted the translation-update branch May 31, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Translation Area: Documentation of, implementation of or actual translation of text V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update translation to Spanish (CLI)
4 participants