Fix ns argument #1147
Merged
Fix ns argument #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattias-p
added
T-Bug
mattias-p
requested review from
matsduf,
hannaeko,
tgreenx and
marc-vanderwal
The database schema was updated to store capitalized module names instead of uppercase module names. Here we make get_test_results understand the new format.
marc-vanderwal
approved these changes
Jan 23, 2024
tgreenx
approved these changes
Jan 23, 2024
mattias-p
added
the
T-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a bug in get_test_results. The RPCAPI reference specifies that
nsarguments should sometimes be included in the results, but this functionality was broken since last release.Context
The bug was introduced in #1092 and discovered while testing #1145.
The cause of the bug is that the database schema was changed to use capitalized names instead of uppercase module names, and get_test_results was not updated accordingly.
Changes
This PR updates get_test_results to understand the new database schema.
How to test this PR
Run
zmtest seand see that all entries from theNameservermodule include annsargument.