Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated "creation_time" key #1081

Merged
1 commit merged into from Feb 9, 2023
Merged

Remove deprecated "creation_time" key #1081

1 commit merged into from Feb 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2023 •
edited by ghost
Loading

Purpose

Remove a deprecated key. "creation_time" replaced by "created_at".

Context

#1063

Changes

  • update code (DB.pm, PostgreSQL.pm)
  • update documentation (API.pm)
  • update tests (test01.t, batches.t)

How to test this PR

Test should pass.

@ghost ghost added the V-Major Versioning: The change gives an update of major in version. label Feb 9, 2023
@ghost ghost added this to the v2023.1 milestone Feb 9, 2023
@ghost ghost linked an issue Feb 9, 2023 that may be closed by this pull request
Remove "creation_time" key from the return value of API methods "get_test_results" and "get_test_history" #1063
Closed
marc-vanderwal
marc-vanderwal approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

matsduf
matsduf approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@ghost ghost merged commit c2b3dd0 into zonemaster:develop Feb 9, 2023
@ghost ghost deleted the remove-deprecated-creation-time branch February 9, 2023 17:54
@ghost ghost mentioned this pull request Feb 10, 2023
Closed
@marc-vanderwal
Copy link
Contributor

Release testing successful:

  • Unit tests pass;
  • No creation_time key appears anymore in the output of the domain_history method;
  • No creation_time key appears anymore in the error output of add_batch_job when another batch is running.

@marc-vanderwal marc-vanderwal added the S-ReleaseTested Status: The PR has been successfully tested in release testing label May 31, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattias-p mattias-p Awaiting requested review from mattias-p

@hannaeko hannaeko Awaiting requested review from hannaeko

@tgreenx tgreenx Awaiting requested review from tgreenx

Assignees
No one assigned
Labels
S-ReleaseTested Status: The PR has been successfully tested in release testing V-Major Versioning: The change gives an update of major in version.
Projects
None yet
Milestone
v2023.1
Development

Successfully merging this pull request may close these issues.

Remove "creation_time" key from the return value of API methods "get_test_results" and "get_test_history"
2 participants
@marc-vanderwal @matsduf