Use Net::IP::XS directly #1053
Merged
Use Net::IP::XS directly #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
approved these changes
Sep 19, 2022
mattias-p
requested review from
a user,
tgreenx,
hannaeko and
marc-vanderwal
hannaeko
approved these changes
Sep 22, 2022
marc-vanderwal
approved these changes
Sep 22, 2022
matsduf
added
the
V-Patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove dependency on (to be deprecated) Zonemaster::Engine::Net::IP.
Context
In zonemaster/zonemaster-engine#1119 Zonemaster::Engine::Net::IP we're dropping support for Net::IP.
The issue zonemaster/zonemaster-engine#1129 has been created to deprecate Zonemaster::Engine::Net::IP, with the intended migration path being to use Net::IP::XS directly.
Changes
Calls into Zonemaster::Engine::Net::IP are replaced with calls into Net::IP::XS.
How to test this PR
This change is covered by existing tests in
t/validator.t.