Provide a module for common tasks when testing Zonemaster::Backend #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
ghost
requested review from
mattias-p
reviewed
May 16, 2022
added 7 commits
May 16, 2022 19:27
The database file lives in a temporary directory that is removed on exit (use of the CLEANUP option).
|
Travis fails because of a bug I introduced in zonemaster/zonemaster-engine#1045. I've created zonemaster/zonemaster-engine#1068 to fix it. |
mattias-p
approved these changes
May 18, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Unit testing Zonemaster::Backend might require to regularly create a new testing environment with clean database for instance. The goal is to provide a simple module that can be loaded to access common methods while testing the Backend.
Context
n/a
Changes
TestUtil.pmmoduleHow to test this PR
Tests should pass.