Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Add the PATCH method for api/module/:name/authorization #246

Closed
ezimuel opened this issue Jan 21, 2015 · 3 comments
Closed

Add the PATCH method for api/module/:name/authorization #246

ezimuel opened this issue Jan 21, 2015 · 3 comments
Milestone

Comments

@ezimuel
Copy link
Contributor

ezimuel commented Jan 21, 2015

We need to support the PATCH for api/module/:name/authorization to add/update authorization for only one service. Right now, we have to PUT authorizations for all the services. This needs comes from the new UI that I'm implementing, I have specific pages per service.

@weierophinney
Copy link
Member

I've started looking at this, and discovered that we're using ZF\Configuration's patch method internally. That method utilizes ArrayUtils::merge(), which should perform a patch operation at this time.

The question is: does the PUT method work like you want PATCH to work? Or is it overwriting values?

@ezimuel
Copy link
Contributor Author

ezimuel commented Jan 31, 2015

@weierophinney the PUT works like a PATCH. For the new UI needs it's ok. I'm not sure that we want to support this behaviour, sounds quite strange for a PUT.

@weierophinney
Copy link
Member

We could deprecate PUT and have it return some warning in the payload, and then implement PATCH... and have it do what it's doing now.

weierophinney added a commit to weierophinney/zf-apigility-admin that referenced this issue Feb 2, 2015
Implemented PATCH as an HTTP method for the authorization service, and
deprecated PUT.
weierophinney added a commit to weierophinney/zf-apigility-admin that referenced this issue Feb 2, 2015
Implemented PATCH as an HTTP method for the authorization service, and
deprecated PUT.
ezimuel added a commit that referenced this issue Feb 6, 2015
[#246] Authorization changes should occur with PATCH
steverhoades pushed a commit to steverhoades/zf-apigility-admin that referenced this issue Mar 30, 2015
Implemented PATCH as an HTTP method for the authorization service, and
deprecated PUT.
@ezimuel ezimuel closed this as completed Jun 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants