Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Option To Disable Log Files #7

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Config Option To Disable Log Files #7

merged 3 commits into from
Jan 18, 2024

Conversation

1A3Dev
Copy link

@1A3Dev 1A3Dev commented Jan 17, 2024

  • Added a config option to disable logging to disk.

@yukieiji yukieiji self-requested a review January 18, 2024 01:39
yukieiji
yukieiji requested changes Jan 18, 2024
View reviewed changes
Copy link
Owner

@yukieiji yukieiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I just had one point I wanted to check, please confirm.

src/Config/ConfigManager.cs Outdated Show resolved Hide resolved
@1A3Dev 1A3Dev requested a review from yukieiji January 18, 2024 02:04
@yukieiji
Copy link
Owner

Thanks for the change, the build looks good, so I'll merge it in.

@yukieiji yukieiji merged commit 2268142 into yukieiji:master Jan 18, 2024
@yukieiji
Copy link
Owner

It can be downloaded from the following URL : https://github.com/yukieiji/UnityExplorer/actions/runs/7564416318

@1A3Dev 1A3Dev deleted the disk-log-toggle branch January 30, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukieiji yukieiji yukieiji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1A3Dev @yukieiji