fix: update timezone in test #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default time value assertion in the test_default_local_var_recv() function
uses the "GMT" time zone, but local.go when creating a default TIME value uses
a "UTC" time standard. This causes tests to fail when run in the UK (BST):
```
--- FAIL: TestTester (0.00s)
--- FAIL: TestTester/empty_and_notset_value_test (0.00s)
runner_test.go:386: Test case "default value check" raises error: Assertion Error: Assertion error: expect=Thu, 01 Jan 1970 01:00:00 GMT, actual=Thu, 01 Jan 1970 00:00:00 GMT
FAIL
```
To resolve this, update the test to use "UTC".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default time value assertion in the
test_default_local_var_recv()function uses the "GMT" time zone, butlocal.gowhen creating a defaultTIMEvalue uses a "UTC" time standard. This causes tests to fail when run in the UK (BST):To resolve this, update the test to use "UTC".