Additional builtin variables #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for this variable was removed as part of the "Pizza" release of Fastly VCL in June 2021. https://developer.fastly.com/reference/changes/2021/06/vcl-changes#withdrawn-documentation
ysugimoto
approved these changes
Jan 23, 2024
interpreter/variable/shared.go
Outdated
| case WAF_FAILURES, | ||
| "waf.php_injection_score", | ||
| "waf.rce_score": | ||
| case WAF_FAILURES, WAF_PHP_INJECTION_SCORE, WAF_RCE_SCORE: |
There was a problem hiding this comment.
According to waf.php_injection_score and waf.rce_score , waf.php_injection_score and waf.rce_score could be set.
There was a problem hiding this comment.
Thanks for noticing that! I had fixed the typo in predefined.yml but forgot to actually make the related changes in the interpreter. Done.
|
@richardmarshall Thanks! This PR should be merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation for undocumented built-in variables:
fastly_info.h2.fingerprintfastly_info.request_idclient.sess_timeoutAdditional fixes
waf.php_injection_scoreandwaf.rce_score..url. It is difficult to show confirmation that this property is valid since the fiddle tool doesn't allow VCL definitions of backends so see attached screenshot.Screenshot of Fastly console showing no errors with activated service using
.urlprobe value: