Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data cleaning notebook and rewrite spiders code #2

Merged
merged 29 commits into from
Jul 3, 2019
Merged

Add data cleaning notebook and rewrite spiders code #2

merged 29 commits into from
Jul 3, 2019

Conversation

yoyotruly
Copy link
Owner

@yoyotruly yoyotruly commented Jun 28, 2019 •
edited
Loading

Changes include:

  • Added notebook for data cleaning and EDA
  • Finished vivino spider
  • Change lcbo spider into a scrapy project
  • Updated settings, pipelines and items for both to improve crawler performance and handle http errors
  • Added docstrings and comments to improve readability
  • Refactored code per previous review

@yoyotruly yoyotruly requested a review from brezhang June 28, 2019 04:40
@yoyotruly yoyotruly merged commit fb424fc into master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brezhang brezhang Awaiting requested review from brezhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yoyotruly