This repository has been archived by the owner on Nov 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbertenasco
force-pushed
the
develop
branch
from
September 15, 2020 19:07
28c47ad
to
15b9a5d
Compare
fubuloubu
reviewed
Sep 15, 2020
lbertenasco
force-pushed
the
feat/delegated-controller
branch
from
September 15, 2020 19:17
12f1f25
to
b123b63
Compare
milkyklim
force-pushed
the
feat/delegated-controller
branch
4 times, most recently
from
September 24, 2020 20:59
3fb4e02
to
0641a47
Compare
fubuloubu
reviewed
Sep 24, 2020
storming0x
reviewed
Sep 24, 2020
milkyklim
approved these changes
Sep 26, 2020
lbertenasco
force-pushed
the
feat/delegated-controller
branch
from
October 5, 2020 14:09
5b72a78
to
7dc5d4b
Compare
milkyklim
force-pushed
the
feat/delegated-controller
branch
from
October 7, 2020 17:30
b134551
to
8460f01
Compare
milkyklim
force-pushed
the
feat/delegated-controller
branch
2 times, most recently
from
October 7, 2020 17:35
6669b12
to
6dab3d3
Compare
fubuloubu
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this matches on-chain (ignoring comments/interface changes) then g2g
@lbertenasco can you confirm that this one is fine? I'll create another PR for solc 0.5.17 update. |
banteg
pushed a commit
that referenced
this pull request
Oct 12, 2020
* feat: add DelegatedController * feat: add DelegatedVault interface * fix: add missing functions and rename Vault to DelegatedVault * fix: lint * chore: revert version for contract Co-authored-by: milkyklim <10698619+milkyklim@users.noreply.github.com>
banteg
added a commit
that referenced
this pull request
Oct 12, 2020
* test: add test for proxy issue * fix: force an invalid-opcode if function does not return * feat: exploit and fix tests * fix: use global gitignore * feat: move unlocked accounts from brownie config to conftest * fix: test proxy exploit * fix: delete duplicate test for strategy proxy * feat: add black config * fix: update to the latest ganache-cli * fix: revert to default black config * chore: add comment on throwInvalidOpcode * chore: updates curve voter proxy to latest proxy address * feat: replace strategy proxy * fix: exploit test * feat: add 3crv strategy by orb * feat: add sbtc deployment sanity check * feat: assert strategy doesn't break withdrawals * feat: add check for vault balance * feat: add strategy curve 3crv voter proxy * feat: add keeper role to 3pool strat * feat: update strategy proxy * feat: assert yearn's success * fix: do not assert success * feat: add evil gauge test * feat: adds set proxy by governance and fixes lint * fix: force lock on proxy after strategy harvest * feat: enhance CI and formatting (#27) * feat: add pre-commit formatting husky hook * feat: add support for commitlint * feat: add simple general rules with .editconfig * ci: add commitlint * ci: add caching for linting jobs * ci: fix black arguments * style: update formatting in python file * ci: update versions of actions * ci: add caching for python in test workflow * ci: bump ganache version and fix flag * ci: add support for black config * ci: fix formatting * ci: fix black config * ci: prevent ci double trigger * ci: update brownie test paths * chore: remove .editorconfig * docs: add readme and contribute guideline (#35) * docs: add readme file for running project and contributing * docs: add readme and contributing md * docs: add issue template * chore: update issue template * chore: update bug template * docs: refactor contibution guide * docs: update docs with missing commands * ci: add .md docs to linting rules * docs: add bash formatting Co-authored-by: milkyklim <10698619+milkyklim@users.noreply.github.com> * ci: fallback to black defaults (#39) * ci: ditch black config, fallback to defaults * style: format python files * fix: fix typo in ci * feat: add DelegatedController (#5) * feat: add DelegatedController * feat: add DelegatedVault interface * fix: add missing functions and rename Vault to DelegatedVault * fix: lint * chore: revert version for contract Co-authored-by: milkyklim <10698619+milkyklim@users.noreply.github.com> * chore: update contracts version to 0.5.17 (#41) * fix: bump solc version * fix: bump solc version fix * fix: bump all solc to 0.5.17 * chore: bump DelegatedController.sol version to 0.5.17 Co-authored-by: Luciano Bertenasco <lbertenasco@gmail.com> * ci: fix caching and triggered events (#43) * fix: remove some cached paths * chore: change when test are triggered * ci: update tokens * docs: update SECURITY.md (#36) * docs: update SECURITY.md as discussed with protocol devs: - add explicit security policy - simplify bug bounty program - reference security team and yearn-security - add myself as point of contact * docs: add minimal style changes Co-authored-by: milkyklim <10698619+milkyklim@users.noreply.github.com> * fix: adds missing lock method to VoterProxy interface * fix: don't increase amount if zero crv available * feat: test migration path * feat: add 3crv deployment test * feat: deploy strategy proxy in evil gauge test * fix: proxy exploit test * fix: rename busd strategy * feat: add harvested event to 3crv strat * feat: track lifetime strategy earnings * feat: simplify events * feat: add harves event to sbtc and y * feat: remove keeper, add strategist rewards 3crv * fix: pretty format * fix: remove migration tests * feat: add 3crv strategy to config test * fix: remove exploit tests for fixed stuff * fix: fix revert message check Co-authored-by: Bryant Eisenbach <fubuloubu@gmail.com> Co-authored-by: banteg <banteeg@gmail.com> Co-authored-by: milkyklim <10698619+milkyklim@users.noreply.github.com> Co-authored-by: Doug Molina <dmolina79@users.noreply.github.com> Co-authored-by: Daniel Lehnberg <daniel.lehnberg@protonmail.com> Co-authored-by: dmolina79 <doug.molinam@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.