Fix peer list bugs for benchmarking #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peer-list was ignoring the last line if it did not end with a "\n" Benchmark warmup failed if --peer-list was used (introduced in round-robin peer selection).
|
@prashantv, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blampe and @abhinav to be potential reviewers |
| origArgs := os.Args | ||
| defer func() { os.Args = origArgs }() | ||
|
|
||
| const numServers = 5 |
There was a problem hiding this comment.
Why make this a constant here? It's not used anywhere else. Just for readability?
There was a problem hiding this comment.
Yeah just for readability
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer-list was ignoring the last line if it did not end with a "\n"
Benchmark warmup failed if --peer-list was used (introduced in
round-robin peer selection, #61).
Fixes #70