Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adress some late codereview feedback on #238 #240

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Conversation

robbertvanginkel
Copy link
Contributor

There were some late comments on #238, addressing them here.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #240 into dev will decrease coverage by <.01%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #240      +/-   ##
==========================================
- Coverage   93.89%   93.88%   -0.01%     
==========================================
  Files          42       42              
  Lines        2308     2306       -2     
==========================================
- Hits         2167     2165       -2     
  Misses         88       88              
  Partials       53       53
Impacted Files Coverage Δ
options.go 94.87% <ø> (ø) ⬆️
transport.go 93.81% <100%> (ø) ⬆️
request.go 100% <100%> (ø) ⬆️
protobuf/filedescriptorsets.go 100% <100%> (ø) ⬆️
encoding/protobuf.go 88.46% <93.33%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee304d0...664ba36. Read the comment docs.

encoding/protobuf.go Outdated Show resolved Hide resolved
transport.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for circling back for these!

@robbertvanginkel robbertvanginkel merged commit 8bd7036 into dev Oct 9, 2018
@robbertvanginkel robbertvanginkel deleted the robbert/feedback branch September 9, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants