Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support -H, -B, --jaeger for headers and baggage #121

Merged
merged 17 commits into from
Nov 2, 2016
Merged

Support -H, -B, --jaeger for headers and baggage #121

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8dab554
Add support for -H, -B, --jaeger headers, baggage, and jaeger
kriskowal Oct 19, 2016
d575f11
Clarify changelog
kriskowal Oct 22, 2016
84cc0de
Thread tracer through transports
kriskowal Oct 22, 2016
6226778
Make explicit tracer required to construct a transport
kriskowal Oct 22, 2016
d6d5515
Factor out getTracer
kriskowal Oct 22, 2016
8336d81
Separate routing work
kriskowal Oct 22, 2016
466559e
Threaded tracer through http
kriskowal Oct 22, 2016
e927a7c
Add integration test for baggage and headers over TChannel
kriskowal Nov 1, 2016
4598a67
Typo fix
kriskowal Nov 1, 2016
843a936
Reenable trace enabled tests
kriskowal Nov 1, 2016
9f9245f
Fix import grouping
kriskowal Nov 2, 2016
9b85a05
Use light options pattern for newServer test helper
kriskowal Nov 2, 2016
8b3169b
Use light options pattern for newServer test helper
kriskowal Nov 2, 2016
34b480b
Nits
kriskowal Nov 2, 2016
a11503b
Add tests for overridden headers
kriskowal Nov 2, 2016
7cea315
Explain the shallow copy of the request object in tchannel
kriskowal Nov 2, 2016
d2515f2
Address nits
kriskowal Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Threaded tracer through http
  • Loading branch information
@kriskowal
kriskowal committed Nov 2, 2016
commit 466559ea7cdab8f4ec0b420c4e4d8f28315859cc
1 change: 0 additions & 1 deletion transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ func getTransport(opts TransportOptions, encoding encoding.Encoding, tracer open
return transport.NewTChannel(topts)
}

// TODO thread tracer through HTTP
hopts := transport.HTTPOptions{
SourceService: opts.CallerName,
TargetService: opts.ServiceName,
Expand Down