Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Quote bugfix #47

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Quote bugfix #47

wants to merge 3 commits into from

Conversation

mehmetcansahin
Copy link
Contributor

@mehmetcansahin mehmetcansahin commented Aug 25, 2022 •
edited
Loading

y21
y21 requested changes Aug 25, 2022
View reviewed changes
src/queryselector/parser.rs Outdated Show resolved Hide resolved
@y21
Copy link
Owner

y21 commented Aug 25, 2022

Can you also apply this logic to the Some(c @ b'~' | c @ b'^' | c @ b'$' | c @ b'*') => { match arm, so it also accepts quotes in p[id~="test"]?

mehmetcansahin and others added 2 commits August 25, 2022 19:53
@mehmetcansahin @y21
Update src/queryselector/parser.rs
740e6d0 
Co-authored-by: Timo <30553356+y21@users.noreply.github.com>
@mehmetcansahin
fix parse_attribute for a quote
647b01e
@mehmetcansahin
Copy link
Contributor Author

Thanks for your suggestion. I applied it on the other match arm (Some(c @ b'~' | c @ b'^' | c @ b'$' | c @ b'*').

y21
y21 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Owner

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looks good
bors r+

bors bot pushed a commit that referenced this pull request Aug 25, 2022
@mehmetcansahin
Quote bugfix (#47)
9fe1305 
related: [query_selector cannot parse meta[property=og:title]](#46)

Co-authored-by: mehmetcan <2010841+mehmetcansahin@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Quote bugfix [Merged by Bors] - Quote bugfix Aug 25, 2022
@bors bors bot closed this Aug 25, 2022
@mehmetcansahin mehmetcansahin deleted the query_selector_quote branch August 25, 2022 17:15
@y21
Copy link
Owner

y21 commented Aug 25, 2022

I published a new version on crates.io with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehmetcansahin @y21