Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect link to MDN in doc for Tag innerText #50

Closed
kelko opened this issue Oct 5, 2022 · 1 comment
Closed

Incorrect link to MDN in doc for Tag innerText #50

kelko opened this issue Oct 5, 2022 · 1 comment

Comments

@kelko
Copy link
Contributor

kelko commented Oct 5, 2022 •
edited
Loading

Current code for HTMLTag innerText links:

 /// Equivalent to [Element#innerText](https://developer.mozilla.org/en-US/docs/Web/API/Element/innerText) in browsers)

But the linked site does not exist (404), the correct link would be https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/innerText (HTMLElement, not the generic Element)

BTW: In the doc comments for all three "rendering" methods there seems to be a ) too many.
kelko added a commit to kelko/tl that referenced this issue Oct 8, 2022
@kelko
Fix MDN-related doc comments (y21#50)
a77c5a8 
- link to innerText was wrong
- had unnecessary closing parenthesis
@kelko
Copy link
Contributor Author

kelko commented Oct 8, 2022

PR created ( #51 )

y21 added a commit that referenced this issue Jan 29, 2024
@y21
Merge pull request #51 from kelko/bugfix/incorrect_mdn_link_innertext
d6f0792 
Fix MDN-related doc comments (#50)
@y21 y21 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelko @y21