Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getRasterizedGlyph null and undefined check #4596

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Add getRasterizedGlyph null and undefined check #4596

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c28c8
Add getRasterizedGlyph null and undefined check
lewis-sanchez Jul 14, 2023
78aad11
Minor clean up
lewis-sanchez Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add getRasterizedGlyph null and undefined check
  • Loading branch information
@lewis-sanchez
lewis-sanchez committed Jul 14, 2023
commit d2c28c819f6127e1fdf8ea013b0e55f1638b1ccf
5 changes: 5 additions & 0 deletions addons/xterm-addon-canvas/src/BaseRenderLayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,11 @@ export abstract class BaseRenderLayer extends Disposable implements IRenderLayer
protected _drawChars(cell: ICellData, x: number, y: number): void {
const chars = cell.getChars();
this._cellColorResolver.resolve(cell, x, this._bufferService.buffer.ydisp + y);

if (this._charAtlas === undefined || this._charAtlas === null) {
return;
}

let glyph: IRasterizedGlyph;
if (chars && chars.length > 1) {
glyph = this._charAtlas.getRasterizedGlyphCombinedChar(chars, this._cellColorResolver.result.bg, this._cellColorResolver.result.fg, this._cellColorResolver.result.ext);
Expand Down