Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper height and fix alignment for positioned overview ruler decorations #3687

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented Mar 16, 2022

fixes #3683
when width is 15px
Screen Shot 2022-03-16 at 1 22 20 PM
when width is 14px
Screen Shot 2022-03-16 at 1 22 47 PM

@meganrogge meganrogge requested a review from Tyriar March 16, 2022 17:24
@meganrogge meganrogge self-assigned this Mar 16, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone Mar 16, 2022
src/browser/Decorations/OverviewRulerRenderer.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar closed this Mar 16, 2022
auto-merge was automatically disabled March 16, 2022 17:47

Pull request was closed

@Tyriar Tyriar reopened this Mar 16, 2022
@meganrogge meganrogge merged commit fd3b22e into xtermjs:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment for overview ruler decorations on the same line is off
2 participants