Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about Caps Lock in login screen #345

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Added info about Caps Lock in login screen #345

merged 2 commits into from
Oct 17, 2021

Conversation

przebor
Copy link
Contributor

@przebor przebor commented Oct 14, 2021

Hello 👋
I saw that there's no info about "Caps Lock being enabled" on Spot login screen, so...
I implemented it.

Please let me know if something's wrong with my code (I hope not haha)

@xou816
Copy link
Owner

xou816 commented Oct 15, 2021

Hi! This looks absolutely fine, thank you for your contribution!! :) I merely have one question atm: is the explicit dependency on gdk4-sys needed? can we work around that by updating our version of gdk4?

@przebor
Copy link
Contributor Author

przebor commented Oct 15, 2021

Ohh i just realized we don't need that.
I was using gdk4-sys to check caps lock state but it was unsafe so I did it other way and forgot about adding it there.
When I get back to my PC, I will remove the dependency.

Updated cargo-sources.json


Remove gdk4-sys from sources

(oops)
@przebor
Copy link
Contributor Author

przebor commented Oct 15, 2021

Removed gdk4-sys from Cargo.toml and cargo-sources.json and squashed commits.
Should be fine now.

@xou816
Copy link
Owner

xou816 commented Oct 15, 2021

Perfect then :) there's just something I forgot, could you run ninja spot-pot -C target and commit the modified files?

@przebor
Copy link
Contributor Author

przebor commented Oct 16, 2021

Should be fine now :)

@xou816
Copy link
Owner

xou816 commented Oct 17, 2021

Perfect, thanks!! merging this :)

@xou816 xou816 merged commit 2f5d707 into xou816:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants