Add endpoint to lists invited groups of a project #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Thanks @habnux, but it seems you missed a few bits. I've made some comments but will also add a commit with the fixes so this one can be merged 👍🏻
projects.go
Outdated
| type ListProjectInvidedGroupOptions struct { | ||
| ListOptions | ||
| Search *string `url:"search,omitempty" json:"search,omitempty"` | ||
| SharedMinAccessLevel *AccessLevelValue `url:"shared_min_access_level,omitempty" json:"shared_min_access_level,omitempty"` |
There was a problem hiding this comment.
According to the docs this should be MinAccessLevel (min_access_level).
projects.go
Outdated
Comment on lines
1142
to
1144
| // ListProjectInvidedGroupOptions represents the available ListProjectsInvitedGroups() options. | ||
| // | ||
| // GitLab API docs: https://docs.gitlab.com/ee/api/projects.html#list-a-projects-invited-groups |
There was a problem hiding this comment.
Please try to keep comments below 80 chars:
Suggested change
| // ListProjectInvidedGroupOptions represents the available ListProjectsInvitedGroups() options. | |
| // | |
| // GitLab API docs: https://docs.gitlab.com/ee/api/projects.html#list-a-projects-invited-groups | |
| // ListProjectInvidedGroupOptions represents the available | |
| // ListProjectsInvitedGroups() options. | |
| // | |
| // GitLab API docs: | |
| // https://docs.gitlab.com/ee/api/projects.html#list-a-projects-invited-groups |
projects.go
Outdated
Comment on lines
1149
to
1150
| Relation []string `url:"relation,omitempty" json:"relation,omitempty"` | ||
| WithCustomAttributes bool `url:"with_custom_attributes,omitempty" json:"with_custom_attributes,omitempty"` |
There was a problem hiding this comment.
These need to be pointers and it seems this code is not formatted properly:
Suggested change
| Relation []string `url:"relation,omitempty" json:"relation,omitempty"` | |
| WithCustomAttributes bool `url:"with_custom_attributes,omitempty" json:"with_custom_attributes,omitempty"` | |
| Relation *[]string `url:"relation,omitempty" json:"relation,omitempty"` | |
| WithCustomAttributes *bool `url:"with_custom_attributes,omitempty" json:"with_custom_attributes,omitempty"` |
projects.go
Outdated
| // ListProjectsInvitedGroups lists invited groups of a project | ||
| // | ||
| // GitLab API docs: https://docs.gitlab.com/ee/api/projects.html#list-a-projects-invited-groups | ||
| func (s *ProjectsService) ListProjectsInvitedGroups(pid interface{}, opt *ListProjectInvidedGroupOptions, options ...RequestOptionFunc) (*Response, error) { |
There was a problem hiding this comment.
This function should also return a *ProjectGroup instead of only the raw response.
projects.go
Outdated
| } | ||
|
|
||
| return s.client.Do(req, nil) | ||
| } |
There was a problem hiding this comment.
Following the ordering in the docs, this method should be placed between Star and Unstar.
projects_test.go
Outdated
| @@ -647,6 +647,21 @@ func TestListProjectForks(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestListProjectsInvitedGroups(t *testing.T) { | |||
There was a problem hiding this comment.
A test like this doesn't actually test anything, so probably best to remove it.
svanharmelen
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds following endoint https://docs.gitlab.com/ee/api/projects.html#list-a-projects-invited-groups