Add ContainerRegistrySize field to Statistics struct
#1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ContainerRegistrySizefield is missing from theStatisticsstruct.The public GitLab API returns the
container_registry_sizefield for project data. E.g. https://docs.gitlab.com/ee/api/projects.html#list-user-projects.The public GitLab API does not return the
container_registry_sizefield for group data. Thus, this change would cause that we always return the null value forContainerRegistrySizewhen fetching groups, which is not optimal. However, we already always return the null value for thecommit_countfield in theStatisticsstruct when fetching groups, as we use the sameStatisticsstruct for project and group data.