Add isPiped() method to \cli\Table #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method to `\cli\Table` to check whether output is being displayed in terminal or is being piped to another command or redirect. If output is being piped, table should be output as tab-separated text rather than with ASCII borders.
| foreach ($this->_rows as $row) { | ||
| \cli\line($this->renderPipedRow($row)); | ||
| } | ||
| exit; |
There was a problem hiding this comment.
I think this should just return. We don't want to quit the entire application after rendering the table out, there could still be work that needs to be done.
There was a problem hiding this comment.
Ah, you're right... this could be called as part of another command. I'll fix this.
|
Excellent addition! One minor change and I'll merge it in. Thanks! |
Since \cli\Table::display() will be called from another command, don't assume that the script is done - there might still be work to do.
|
This will be really cool, thanks for merging! I'll be using this as part of some commands in wp-cli: wp-cli/wp-cli#161 |
jlogsdon
added a commit
that referenced
this pull request
Sep 15, 2012
Add isPiped() method to \cli\Table
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to
\cli\Tableto check whether output is being displayedin terminal or is being piped to another command or redirect. If output
is being piped, table should be output as tab-separated text rather than
with ASCII borders.
This is the same output behavior that other unix commands such as
mysqluse to determine whether to output a graphical table or tab-delimited text.