Add created_by and modified_by fields in ScriptVersion #354
Conversation
| readonly_fields = ('created_date', 'created_by', 'modified_date', 'modified_by') | ||
|
|
||
| def save_model(self, request, obj, form, change): | ||
| if not change: |
There was a problem hiding this comment.
If this already exists won't we always update created by with the last user? Seems like this should be checking if created by is empty
There was a problem hiding this comment.
Nope! change is True only when updating an existing entry and False when creating a new one.
| @@ -14,6 +14,13 @@ | |||
| <div class="page-header"> | |||
| <h3 id="wooey-script-title">{{ script.script_name }}</h3> | |||
| <p id="wooey-script-description">{{ script.script_description }}</p> | |||
|
|
|||
| <p id="wooey-script-info" style="color:gray"><small> | |||
There was a problem hiding this comment.
This is ok, but I'll probably move it elsewhere. Seems like we're putting a lot of stuff above where users primarily interact with the script.
There was a problem hiding this comment.
Also should handle the none case better than just saying none since created by and modified by won't be filled out for existing scripts. I'd put it as unknown or omit it
There was a problem hiding this comment.
Sounds good. Do you think somewhere a bit more discrete, like a footer?
There was a problem hiding this comment.
I was thinking to put the information in the header, and only put the last modified/version stuff in. like:
And if the user is unknown -- omit it. The version is a combination of That would be {{ script_version }}.{{ script_iteration }}
There was a problem hiding this comment.
With modifier:
Without modifier:
|
Great! |
-Aoption usage changed by setting celery<5created_byandmodified_byfields forScriptVersioncreatedandmodifiedfields forScriptVersion. Currently, I have all of them set to be read-only, but still a bit unsure if this is the best, or should we make these editable?