Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ScriptParameter choices field to text from charfield #351

Merged
merged 9 commits into from
Jul 15, 2022

Conversation

Chris7
Copy link
Member

@Chris7 Chris7 commented Jul 15, 2022

User had a lot of choices, and there is no real reason to limit this field.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #351 (c661659) into master (a5099df) will decrease coverage by 20.39%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           master     #351       +/-   ##
===========================================
- Coverage   72.93%   52.54%   -20.40%     
===========================================
  Files          38       51       +13     
  Lines        2398     3340      +942     
  Branches      356      545      +189     
===========================================
+ Hits         1749     1755        +6     
- Misses        530     1469      +939     
+ Partials      119      116        -3     
Flag Coverage Δ
unittests 52.51% <25.00%> (-20.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wooey/tests/test_views.py 0.00% <0.00%> (ø)
wooey/models/core.py 79.90% <100.00%> (ø)
wooey/tests/mixins.py 0.00% <0.00%> (ø)
wooey/tests/test_tasks.py 0.00% <0.00%> (ø)
wooey/tests/test_template_tags.py 0.00% <0.00%> (ø)
wooey/tests/factories.py 0.00% <0.00%> (ø)
wooey/tests/test_commands.py 0.00% <0.00%> (ø)
wooey/tests/__init__.py 0.00% <0.00%> (ø)
wooey/tests/config.py 0.00% <0.00%> (ø)
wooey/tests/test_utils.py 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5099df...c661659. Read the comment docs.

@Chris7 Chris7 merged commit a4c87d1 into master Jul 15, 2022
@Chris7 Chris7 deleted the change-choice-to-text-field branch July 15, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants