Refactored nanobind so that it works with Py_LIMITED_API #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an ongoing effort to refactor CPython internals to improve its performance. This has serious consequences for tools like nanobind, which rely on various CPython implementation details that are now subject to change. This commit changes nanobind so that it can (optionally) work via the Py_LIMITED_API, which means that it treats all CPython data structures as fully opaque and only accesses them through an official API/ABI with long-term stability. This requires a change that is pending for inclusion into Python 3.11 (issue 39012).
hmenke
reviewed
May 31, 2023
Comment on lines
+202
to
+205
| # Limited API interface only supported in Python >= 3.12 | ||
| if ((Python_VERSION_MAJOR EQUAL 3) AND (Python_VERSION_MINOR LESS 12)) | ||
| set(ARG_STABLE_ABI OFF) | ||
| endif() |
There was a problem hiding this comment.
Why is this set to 3.12? The documentation mentions:
Python 3.2 introduced the Limited API, a subset of Python’s C API.
so I would have assumed that 3.2 is sufficient.
There was a problem hiding this comment.
nanobind depends on a few features that I specifically worked on adding to the stable ABI (search for my name here: https://docs.python.org/3.12/whatsnew/3.12.html). That means they are only usable in stable ABI builds targeting 3.12+ (so not very useful just yet, but good to have for the future).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an ongoing effort to refactor CPython internals to improve its
performance. This has serious consequences for tools like nanobind,
which rely on various CPython implementation details that are now
subject to change.
This commit changes nanobind so that it can (optionally) work via the
Py_LIMITED_API, which means that it treats all CPython data structures
as fully opaque and only accesses them through an official API/ABI with
long-term stability.
This requires a change that is pending for inclusion into Python 3.12
as part of PR 93012.