Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prod/dev awareness to scripts building Detox.framework for easier native development process #621

Merged
merged 4 commits into from
Mar 14, 2018

Conversation

LeoNatan
Copy link
Contributor

Still open: Check in CLI that we are in dev mode and enable this option, or better yet, just call the dev build script

@LeoNatan LeoNatan requested a review from rotemmiz as a code owner March 12, 2018 19:53
@rotemmiz rotemmiz changed the title Add scripts for building dev framework instead of production one [WIP] Add scripts for building dev framework instead of production one Mar 14, 2018
@@ -2,7 +2,7 @@

source $(dirname "$0")/travis_logger.sh

run_f "$(dirname "$0")/bootstrap.sh"
run_f "lerna bootstrap"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck yeah!

@rotemmiz rotemmiz changed the title [WIP] Add scripts for building dev framework instead of production one Internal: Add prod/dev awareness to scripts building Detox.framework for easier native development process Mar 14, 2018
@rotemmiz rotemmiz merged commit b62db86 into master Mar 14, 2018
@rotemmiz rotemmiz deleted the DevFrameworkBuild branch March 14, 2018 20:06
@rotemmiz rotemmiz changed the title Internal: Add prod/dev awareness to scripts building Detox.framework for easier native development process Add prod/dev awareness to scripts building Detox.framework for easier native development process Mar 26, 2018
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants