-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integ. with Jest in terms of logging #1351
Conversation
715e130
to
db66215
Compare
Sure, I'll review it tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d4vidi, I did a quick review of the PR.
There are a few points for the dialogue and a few assignments to me, as I was the one who messed with a couple of files.
But for the most part, that's it.
Good morning, @d4vidi! I've put some more thought into what is suggested by the PR, and actually, I'm coming to a conclusion that we might want to split this PR into two.
So I conclude two thoughts out of this:
So your second PR (if we split #1351) might add an opinionated recommendation to try out the new trace reporter in some of the projects, as soon as the npm package with your jasmine trace reporter is ready. |
2e93dd3
to
399cb34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't lie — to my taste, the current implementation still seems a bit rushed and not well polished.
However, in the light of the circumstances, since we want to roll it out sooner, and as long as it is technically working in a valid way, I have no strong objections to it, there's nothing blocking now, AFAIC.
So, consider it to be approved.
32833e3
to
2d96ee8
Compare
Description:
Fixes #1349.