Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable touch indicators on IOS #640

Closed
Gongreg opened this issue Mar 26, 2018 · 3 comments
Closed

Allow to disable touch indicators on IOS #640

Gongreg opened this issue Mar 26, 2018 · 3 comments

Comments

@Gongreg
Copy link

Gongreg commented Mar 26, 2018

We are implementing screenshot tests when running detox, there is a issue that we have to wait 500ms just to be sure that all touch indicators have disappeared. It would be nice to have an option to disable them.

@Naoto-Ida
Copy link

We have the same use-case and would love to be able to disable it.

@rotemmiz
Copy link
Member

rotemmiz commented Jun 21, 2018

#751 still needs JS support.
Current state of this PR will allow disabling of touch indicator by adding disableTouchIndicator to launchArgs.
The missing piece currently is a way to preserve launch args and parameters passed to launchApp upon recovery from app crash.
The easiest way of doing it is by saving them inside Device.js and exposing a function (something like getLastLaunchParams()) that will be in app crash recovery.

This is a fairly simple and straight forward solution IMO, other ideas are welcome of course.

BTW,
I would prefer the parameter to be positive instead of negative, enableTouchIndicator, default true/YES.

@LeoNatan
Copy link
Contributor

If it's enabled, the param should be disable. Naming should follow the rules of "what happens if the param is not there".

LeoNatan pushed a commit that referenced this issue Aug 23, 2018
* Add support for disabling touch indicators with launch args

* Don't read user defaults on every touch

* Use launchApp instead of deprecated relaunchApp

Closes #640
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants