Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydration map to compiled output #51

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Add hydration map to compiled output #51

merged 5 commits into from
Oct 13, 2021

Conversation

matthewp
Copy link
Contributor

This adds a hydration map to the compiled output. This is a list of all imports and the specifier. This will be used to find the component's client path for hydration purposes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2021

🦋 Changeset detected

Latest commit: b6bac57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small comments, but I'm on board with this general approach.

internal/js_scanner/js_scanner.go Show resolved Hide resolved
internal/js_scanner/js_scanner.go Show resolved Hide resolved
internal/printer/printer_test.go Outdated Show resolved Hide resolved
internal/printer/print-to-js.go Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 3a336ef into main Oct 13, 2021
@matthewp matthewp deleted the hydration-map branch October 13, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants